Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: webContents.print({ silent: true }) not working correctly #39095

Merged
merged 1 commit into from Jul 18, 2023
Merged

fix: webContents.print({ silent: true }) not working correctly #39095

merged 1 commit into from Jul 18, 2023

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jul 13, 2023 •
edited

Backport of #38741
Backport of #38976

Closes #39108

See that PR for details.

Notes: Fixed an issue with webContents.print({ silent: true }) not working correctly.

@codebytere codebytere requested a review from a team as a code owner July 13, 2023 19:36
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 13, 2023
@trop trop bot mentioned this pull request Jul 13, 2023
Merged
3 tasks
@trop trop bot added 25-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 13, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 13, 2023
@trop trop bot mentioned this pull request Jul 13, 2023
Merged
3 tasks
@codebytere codebytere mentioned this pull request Jul 13, 2023
Closed
3 tasks
@codebytere codebytere requested review from a team and miniak July 17, 2023 07:38
@codebytere codebytere merged commit 95aa540 into 25-x-y Jul 18, 2023
14 checks passed
@codebytere codebytere deleted the silent-printing-25 branch July 18, 2023 08:42
@release-clerk
Copy link

release-clerk bot commented Jul 18, 2023

Release Notes Persisted

Fixed an issue with webContents.print({ silent: true }) not working correctly.

@codebytere codebytere mentioned this pull request Jul 18, 2023
Closed
3 tasks
@Hedwig188 Hedwig188 mentioned this pull request Jul 25, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@miniak miniak Awaiting requested review from miniak

Assignees
No one assigned
Labels
25-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @MarshallOfSound