fix: potential crash calling tray.popUpContextMenu()

[codebytere]

Description of Change

Speculative fix for a crash i've been seeing in CI a fair bit recently, but haven't been able to repro locally. It looks like the ElectronMenuModel is going away before this callback is called. We use base::Unretained here which isn't safe if we can't guarantee lifetime which I don't think we can here.

Sample Failure

Stacktrace

Received signal 11 SEGV_MAPERR 000000000018
0   Electron Framework                  0x0000000129ff4632 base::debug::CollectStackTrace(void**, unsigned long) + 18
1   Electron Framework                  0x0000000129fe2393 base::debug::StackTrace::StackTrace() + 19
2   Electron Framework                  0x0000000129ff4581 base::debug::(anonymous namespace)::StackDumpSignalHandler(int, __siginfo*, void*) + 1361
3   libsystem_platform.dylib            0x00007ff8126dedfd _sigtramp + 29
4   ???                                 0x00006000023fd380 0x0 + 105553154003840
5   Electron Framework                  0x0000000129bcc352 base::internal::Invoker<base::internal::BindState<void (electron::TrayIconCocoa::*)(electron::ElectronMenuModel*), base::WeakPtr<electron::TrayIconCocoa>, base::internal::UnretainedWrapper<electron::ElectronMenuModel, base::unretained_traits::MayNotDangle, (base::RawPtrTraits)0>>, void ()>::RunOnce(base::internal::BindStateBase*) + 98
6   Electron Framework                  0x0000000129f66dec base::TaskAnnotator::RunTaskImpl(base::PendingTask&) + 300
7   Electron Framework                  0x0000000129f96f17 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::LazyNow*) + 1655
8   Electron Framework                  0x0000000129f962e4 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() + 132
9   Electron Framework                  0x0000000129f97ae5 non-virtual thunk to base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() + 21
10  Electron Framework                  0x0000000129ffcfbc base::MessagePumpCFRunLoopBase::RunWork() + 204
11  Electron Framework                  0x0000000129ffce93 ___ZN4base24MessagePumpCFRunLoopBase19RunDelayedWorkTimerEP16__CFRunLoopTimerPv_block_invoke + 51
12  Electron Framework                  0x0000000129ffbe32 base::mac::CallWithEHFrame(void () block_pointer) + 10
13  Electron Framework                  0x0000000129ffc42f base::MessagePumpCFRunLoopBase::RunDelayedWorkTimer(__CFRunLoopTimer*, void*) + 63
14  CoreFoundation                      0x00007ff8127a8f69 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20
15  CoreFoundation                      0x00007ff8127a8a58 __CFRunLoopDoTimer + 923
16  CoreFoundation                      0x00007ff8127a85c8 __CFRunLoopDoTimers + 307
17  CoreFoundation                      0x00007ff81278ed06 __CFRunLoopRun + 2010
18  CoreFoundation                      0x00007ff81278de6c CFRunLoopRunSpecific + 562
19  HIToolbox                           0x00007ff81b43c5e6 RunCurrentEventLoopInMode + 292
20  HIToolbox                           0x00007ff81b43c34a ReceiveNextEventCommon + 594
21  HIToolbox                           0x00007ff81b43c0e5 _BlockUntilNextEventMatchingListInModeWithFilter + 70
22  AppKit                              0x00007ff8151c7fad _DPSNextEvent + 927
23  AppKit                              0x00007ff8151c666a -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1394
24  AppKit                              0x00007ff8151b8d19 -[NSApplication run] + 586
25  Electron Framework                  0x0000000129ffdacf base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 511
26  Electron Framework                  0x0000000129ffbec3 base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 131
27  Electron Framework                  0x0000000129f9806b base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) + 539
28  Electron Framework                  0x0000000129f40925 base::RunLoop::Run(base::Location const&) + 437
29  Electron Framework                  0x000000012878cdc2 content::BrowserMainLoop::RunMainMessageLoop() + 146
30  Electron Framework                  0x000000012878f195 content::BrowserMainRunnerImpl::Run() + 37
31  Electron Framework                  0x0000000128789c1a content::BrowserMain(content::MainFunctionParams) + 154
32  Electron Framework                  0x000000012466951c content::RunBrowserProcessMain(content::MainFunctionParams, content::ContentMainDelegate*) + 284
33  Electron Framework                  0x000000012466aa97 content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams, bool) + 631
34  Electron Framework                  0x000000012466a678 content::ContentMainRunnerImpl::Run() + 824
35  Electron Framework                  0x0000000124668a3e content::RunContentProcess(content::ContentMainParams, content::ContentMainRunner*) + 1454
36  Electron Framework                  0x0000000124668d03 content::ContentMain(content::ContentMainParams) + 115
37  Electron Framework                  0x00000001241eeaf0 ElectronMain + 160
38  dyld                                0x000000010b08352e start + 462
[end of stack trace]
✗ Electron tests failed with kill signal SIGSEGV.

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• relevant documentation, tutorials, templates and examples are changed or added
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed a potential crash when calling tray.popUpContextMenu on macOS.

[zcbenz]

Looks good to me based on the stack trace.

[release-clerk]

Release Notes Persisted

Fixed a potential crash when calling tray.popUpContextMenu on macOS.

[trop]

I was unable to backport this PR to "24-x-y" cleanly;
you will need to perform this backport manually.

[trop]

I was unable to backport this PR to "25-x-y" cleanly;
you will need to perform this backport manually.

[trop]

I have automatically backported this PR to "26-x-y", please check out #39313

[trop]

@codebytere has manually backported this PR to "25-x-y", please check out #40271

[trop]

@codebytere has manually backported this PR to "24-x-y", please check out #40272