Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: potential crash calling tray.popUpContextMenu() #40272

Closed
wants to merge 1 commit into from
Closed

fix: potential crash calling tray.popUpContextMenu() #40272

wants to merge 1 commit into from

Conversation

codebytere
Copy link
Member

Backport of #39231.

See that PR for details.

Notes: Fixed a potential crash when calling tray.popUpContextMenu on macOS.

@codebytere codebytere requested a review from a team October 18, 2023 19:35
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 18, 2023
@trop trop bot added 24-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Oct 18, 2023
@trop trop bot mentioned this pull request Oct 18, 2023
Merged
4 tasks
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 18, 2023
@dsanders11
Copy link
Member

Did you mean to backport this to 24-x-y? That branch is unsupported now.

@jkleinsc
Copy link
Contributor

Closing as 24-x-y is no longer supported.

@jkleinsc jkleinsc closed this Oct 18, 2023
@jkleinsc jkleinsc deleted the maybe-fix-menu-crash-24 branch October 18, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
24-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @dsanders11 @jkleinsc