refactor: update WebContentsZoomController
#39428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
electron-cation
bot
added
new-pr 🌱
jkleinsc
approved these changes
Aug 14, 2023
zcbenz
approved these changes
Aug 15, 2023
|
No Release Notes |
|
I was unable to backport this PR to "25-x-y" cleanly; |
trop
bot
added
needs-manual-bp/25-x-y
and removed
target/25-x-y
|
I have automatically backported this PR to "26-x-y", please check out #39495 |
trop
bot
added
in-flight/26-x-y
merged/26-x-y
4 tasks
win32ss
pushed a commit
to win32ss/supermium-electron
that referenced
this pull request
Sep 24, 2023
refactor: update WebContentsZoomController
SpecialAro
added a commit
to SpecialAro/electron
that referenced
this pull request
Oct 27, 2023
This reverts commit 8e3dcc8.
3 tasks
4 tasks
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
refactor: update WebContentsZoomController
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Refs https://codereview.chromium.org/301733006.
Refs #8537
This PR refactors and updates our ZoomController implementation to bring it into line with the current state of
components/zoom/zoom_controller.ccupstream. This is being done as a precursor to supporting tab events inchrome.tabs, which expect data be sent to observers in struct form and contain both new and old zoom values.Relevant Changes
WebContentsZoomObserverinto a standalone fileZoomEventChangeDatastructZoomHostMapChecklist
npm testpassesRelease Notes
Notes: none