-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly track receiver for methods called via ctx bridge #39978
Conversation
43db98a
to
54c9f3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test that verifies the issue in #39891?
@codebytere specifically calling |
075cc5c
to
947d145
Compare
@jkleinsc done! |
Release Notes Persisted
|
I have automatically backported this PR to "27-x-y", please check out #40262 |
I have automatically backported this PR to "28-x-y", please check out #40263 |
…tron#39978) * fix: correctly track receiver for methods called via ctx bridge * spec: test for correct contextBridge passage --------- Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
…tron#39978) * fix: correctly track receiver for methods called via ctx bridge * spec: test for correct contextBridge passage --------- Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Closes #39891
Corrects an issue where functions called over the
contextBridge
were not being called with the expected receiver (this
), leading to errors like the following:Notes: Functions called over the
contextBridge
are now called with the expected receiver (this
)