fix: correctly track receiver for methods called via ctx bridge #39978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
added
target/27-x-y
github-actions
bot
added
the
target/28-x-y
codebytere
force-pushed
the
ctx-bridge-recv
branch
from
43db98a
to
54c9f3c
Compare
|
@codebytere specifically calling |
codebytere
force-pushed
the
ctx-bridge-recv
branch
from
075cc5c
to
947d145
Compare
|
@jkleinsc done! |
jkleinsc
approved these changes
Oct 18, 2023
|
Release Notes Persisted
|
This was referenced Oct 18, 2023
|
I have automatically backported this PR to "27-x-y", please check out #40262 |
trop
bot
added
in-flight/27-x-y
and removed
target/27-x-y
|
I have automatically backported this PR to "28-x-y", please check out #40263 |
trop
bot
added
in-flight/28-x-y
merged/28-x-y
felixrieseberg
pushed a commit
to felixrieseberg/electron
that referenced
this pull request
Oct 25, 2023
…tron#39978) * fix: correctly track receiver for methods called via ctx bridge * spec: test for correct contextBridge passage --------- Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
…tron#39978) * fix: correctly track receiver for methods called via ctx bridge * spec: test for correct contextBridge passage --------- Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39891
Corrects an issue where functions called over the
contextBridgewere not being called with the expected receiver (this), leading to errors like the following:Notes: Functions called over the
contextBridgeare now called with the expected receiver (this)