fix: macOS maximize button shouldn't be disabled just because the window is non-fullscreenable

[tzahola]

Description of Change

This PR fixes this bug: #39833

An earlier PR (cc @codebytere) incorrectly disabled NSWindowZoomButton if the window was non-fullscreenable. However, if a macOS window is non-fullscreenable, the green zoom button turns into a maximize button (with a plus sign instead of the full-screen arrows), so it is still useful and shouldn't be disabled.

Here I'm enabling the button if the window is fullscreenable OR (resizable AND maximizable). I'm also ensuring that this invariant holds whenever any of these 3 flags change (i.e. fullscreenable, resizable, maximizable).

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• relevant documentation, tutorials, templates and examples are changed or added
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed the enabled/disabled behavior of the maximize/fullscreen button of macOS windows

[ckerr]

The code in this PR makes sense to me. And thanks for adding a test!

Holding back on an Approve for now because I'd like feedback from @codebytere. The comment in her previous PR about handling fullsize + maximize + resizable in a way that's consistent cross-platform is tricky so I'd like a second opinion.

[codebytere]

@tzahola missed this initially: this test is failing.

see comment

[tzahola]

@tzahola missed this initially: this test is failing.

Fixed now. Although something still caused a test job to fail with SIGSEGV, but that shouldn't be related. ¯_(ツ)_/¯

[nornagon]

Tray icon related failures are probably fixed by 6602703, merged recently. So, unrelated to this PR :)

[tzahola]

Tray icon related failures are probably fixed by 6602703, merged recently. So, unrelated to this PR :)

Rebased!

[release-clerk]

Release Notes Persisted

Fixed the enabled/disabled behavior of the maximize/fullscreen button of macOS windows

[trop]

I have automatically backported this PR to "27-x-y", please check out #40895

[trop]

I have automatically backported this PR to "28-x-y", please check out #40896

[trop]

I have automatically backported this PR to "29-x-y", please check out #40897

[miniak]

@codebytere I am afraid this fix is causing a regression, just run the default Fiddle test-app and make the window fullscreen by clicking the green semaphore button. You can no longer exit fullscreen as the green semaphore button gets disabled.

Before this PR:

After this PR:

[tzahola]

@codebytere I am afraid this fix is causing a regression, just run the default Fiddle test-app and make the window fullscreen by clicking the green semaphore button. You can no longer exit fullscreen as the green semaphore button gets disabled.

Fix: #40994