Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: macOS maximize button shouldn't be disabled just because the window is non-fullscreenable #40895

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 5, 2024

Backport of #40705

See that PR for details.

Notes: Fixed the enabled/disabled behavior of the maximize/fullscreen button of macOS windows

trop bot and others added 3 commits January 5, 2024 17:15
…dow is non-fullscreenable

Co-authored-by: Tamás Zahola <tzahola@gmail.com>
Co-authored-by: Tamás Zahola <tzahola@gmail.com>
… fullscreenable)` instead of `(resizable && maximizable) && fullscreenable`

Co-authored-by: Tamás Zahola <tzahola@gmail.com>
@trop trop bot added 27-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jan 5, 2024
@jkleinsc jkleinsc merged commit 79be0be into 27-x-y Jan 8, 2024
17 checks passed
@jkleinsc jkleinsc deleted the trop/27-x-y-bp-fix-macos-maximize-button-shouldn-t-be-disabled-just-because-the-window-is-non-fullscreenable-1704474949288 branch January 8, 2024 17:56
Copy link

release-clerk bot commented Jan 8, 2024

Release Notes Persisted

Fixed the enabled/disabled behavior of the maximize/fullscreen button of macOS windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
27-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants