Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure invalid URL loads promises are fulfilled. #41194

Merged

fixup! fix: make sure invalid URL loads promisses are fulfilled.

fb293e0
Select commit
Failed to load commit list.
Merged

fix: make sure invalid URL loads promises are fulfilled. #41194

fixup! fix: make sure invalid URL loads promisses are fulfilled.
fb293e0
Select commit
Failed to load commit list.
trop / Backportable? - 29-x-y completed Feb 1, 2024 in 8h 32m 3s

Backport Failed

This PR was checked and could not be automatically backported to "29-x-y" cleanly

Details

Failed Diff:

diff --cc lib/browser/api/web-contents.ts
index 19660d3cf9,8dc7fc186d..0000000000
--- a/lib/browser/api/web-contents.ts
+++ b/lib/browser/api/web-contents.ts
@@@ -347,13 -360,12 +347,16 @@@ WebContents.prototype.loadURL = functio
        reject(err);
      };
      const finishListener = () => {
 -      if (error) {
 -        rejectAndCleanup(error);
 -      } else {
 -        resolveAndCleanup();
 +      resolveAndCleanup();
 +    };
++<<<<<<< HEAD
 +    const failListener = (event: Electron.Event, errorCode: number, errorDescription: string, validatedURL: string, isMainFrame: boolean) => {
 +      if (isMainFrame) {
 +        rejectAndCleanup(errorCode, errorDescription, validatedURL);
        }
      };
++=======
++>>>>>>> fix: make sure invalid URL loads promisses are fulfilled.
  
      let navigationStarted = false;
      let browserInitiatedInPageNavigation = false;
diff --cc spec/api-web-contents-spec.ts
index f339bad212,4f6185dd4c..0000000000
--- a/spec/api-web-contents-spec.ts
+++ b/spec/api-web-contents-spec.ts
@@@ -514,6 -514,15 +514,18 @@@ describe('webContents module', () => 
          .and.have.property('errno', -355); // ERR_INCOMPLETE_CHUNKED_ENCODING
        s.close();
      });
++<<<<<<< HEAD
++=======
+ 
+     it('subsequent load failures reject each time', async () => {
+       await expect(w.loadURL('file:non-existent')).to.eventually.be.rejected();
+       await expect(w.loadURL('file:non-existent')).to.eventually.be.rejected();
+     });
+ 
+     it('invalid URL load rejects', async () => {
+       await expect(w.loadURL('invalidURL')).to.eventually.be.rejected();
+     });
++>>>>>>> fix: make sure invalid URL loads promisses are fulfilled.
    });
  
    describe('getFocusedWebContents() API', () => {

Annotations

Check failure on line 360 in lib/browser/api/web-contents.ts

See this annotation in the file changed.

@trop trop / Backportable? - 29-x-y

lib/browser/api/web-contents.ts#L356-L360

Patch Conflict
Raw output
++<<<<<<< HEAD
 +    const failListener = (event: Electron.Event, errorCode: number, errorDescription: string, validatedURL: string, isMainFrame: boolean) => {
 +      if (isMainFrame) {
 +        rejectAndCleanup(errorCode, errorDescription, validatedURL);
        }
      };
++=======
++>>>>>>> fix: make sure invalid URL loads promisses are fulfilled.

Check failure on line 360 in lib/browser/api/web-contents.ts

See this annotation in the file changed.

@trop trop / Backportable? - 29-x-y

lib/browser/api/web-contents.ts#L356-L360

Patch Conflict
Raw output
++<<<<<<< HEAD
 +    const failListener = (event: Electron.Event, errorCode: number, errorDescription: string, validatedURL: string, isMainFrame: boolean) => {
 +      if (isMainFrame) {
 +        rejectAndCleanup(errorCode, errorDescription, validatedURL);
        }
      };
++=======
++>>>>>>> fix: make sure invalid URL loads promisses are fulfilled.