Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: WTF-8 decoding issue in node:fs #41673

Merged
merged 1 commit into from Mar 24, 2024
Merged

fix: WTF-8 decoding issue in node:fs #41673

merged 1 commit into from Mar 24, 2024

Conversation

codebytere
Copy link
Member

Description of Change

Closes #41659.

Fixes an issue where emojis weren't properly handled on Windows.

Cherry-pick of libuv/libuv@d09441c - libuv forgot to mask off the high bits from the first byte, so it ended up
always failing the subsequent range check.

Checklist

Release Notes

Notes: Fixed an issue where emojis weren't properly handled on Windows.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/29-x-y PR should also be added to the "29-x-y" branch. target/30-x-y PR should also be added to the "30-x-y" branch. labels Mar 22, 2024
@codebytere codebytere requested a review from a team as a code owner March 22, 2024 15:02
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 22, 2024
@Prinzhorn Prinzhorn mentioned this pull request Mar 22, 2024
Closed
3 tasks
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 23, 2024
@codebytere codebytere merged commit ed28ead into main Mar 24, 2024
24 of 25 checks passed
@codebytere codebytere deleted the node-emoji-fix branch March 24, 2024 19:39
@release-clerk Release Clerk
Copy link

release-clerk bot commented Mar 24, 2024

Release Notes Persisted

Fixed an issue where emojis weren't properly handled on Windows.

This was referenced Mar 24, 2024
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Mar 24, 2024

I have automatically backported this PR to "29-x-y", please check out #41680

@trop trop bot added in-flight/29-x-y and removed target/29-x-y PR should also be added to the "29-x-y" branch. labels Mar 24, 2024
@trop
Copy link
Contributor

trop bot commented Mar 24, 2024

I have automatically backported this PR to "30-x-y", please check out #41681

@trop trop bot added in-flight/30-x-y merged/30-x-y PR was merged to the "30-x-y" branch. merged/29-x-y PR was merged to the "29-x-y" branch. and removed target/30-x-y PR should also be added to the "30-x-y" branch. in-flight/30-x-y in-flight/29-x-y labels Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@nornagon nornagon Awaiting requested review from nornagon

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
merged/29-x-y PR was merged to the "29-x-y" branch. merged/30-x-y PR was merged to the "30-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: fs module on Windows cannot handle special characters
2 participants
@codebytere @deepak1556