Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: WTF-8 decoding issue in node:fs #41680

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Mar 24, 2024

Backport of #41673

See that PR for details.

Notes: Fixed an issue where emojis weren't properly handled on Windows.

@trop trop bot requested a review from a team as a code owner March 24, 2024 19:39
@trop trop bot requested a review from codebytere March 24, 2024 19:39
@trop trop bot mentioned this pull request Mar 24, 2024
3 tasks
@trop trop bot added 29-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 24, 2024
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@codebytere codebytere force-pushed the trop/29-x-y-bp-fix-wtf-8-decoding-issue-in-node-fs--1711309189475 branch from 7772bda to f9d62cc Compare March 25, 2024 09:03
@codebytere codebytere merged commit d3da708 into 29-x-y Mar 25, 2024
13 checks passed
@codebytere codebytere deleted the trop/29-x-y-bp-fix-wtf-8-decoding-issue-in-node-fs--1711309189475 branch March 25, 2024 13:39
Copy link

release-clerk bot commented Mar 25, 2024

Release Notes Persisted

Fixed an issue where emojis weren't properly handled on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
29-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant