Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package <__assertion_handler> as part of libcxx headers #41830

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

deepak1556
Copy link
Member

Description of Change

Refs https://chromium-review.googlesource.com/c/chromium/src/+/5208502

In file included from ../node_modules/node-addon-api/napi.h:5:
In file included from /mnt/vss/_work/1/s/.build/libcxx_headers/include/functional:515:
In file included from /mnt/vss/_work/1/s/.build/libcxx_headers/include/__algorithm/search.h:14:
In file included from /mnt/vss/_work/1/s/.build/libcxx_headers/include/__algorithm/iterator_operations.h:12:
In file included from /mnt/vss/_work/1/s/.build/libcxx_headers/include/__algorithm/iter_swap.h:14:
In file included from /mnt/vss/_work/1/s/.build/libcxx_headers/include/__utility/swap.h:16:
In file included from /mnt/vss/_work/1/s/.build/libcxx_headers/include/__type_traits/is_nothrow_move_constructible.h:15:
In file included from /mnt/vss/_work/1/s/.build/libcxx_headers/include/__type_traits/is_nothrow_constructible.h:17:
In file included from /mnt/vss/_work/1/s/.build/libcxx_headers/include/cstddef:36:
/mnt/vss/_work/1/s/.build/libcxx_headers/include/__assert:13:10: fatal error: '__assertion_handler' file not found
   13 | #include <__assertion_handler> // Note: this include is generated by CMake and is potentially vendor-provided.
      |          ^~~~~~~~~~~~~~~~~~~~~
1 error generated.

Release Notes

Notes: fix missing <__assertion_handler> header when compiling with libc++

@deepak1556 deepak1556 added semver/patch backwards-compatible bug fixes target/29-x-y PR should also be added to the "29-x-y" branch. target/30-x-y PR should also be added to the "30-x-y" branch. labels Apr 11, 2024
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 11, 2024
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 12, 2024
@deepak1556
Copy link
Member Author

Failing tests are unrelated, merging.

@deepak1556 deepak1556 merged commit b446ce7 into main Apr 12, 2024
23 of 25 checks passed
@deepak1556 deepak1556 deleted the robo/fix_libcxx_headers branch April 12, 2024 14:50
Copy link

release-clerk bot commented Apr 12, 2024

Release Notes Persisted

fix missing &lt;__assertion_handler&gt; header when compiling with libc++

@trop
Copy link
Contributor

trop bot commented Apr 12, 2024

I have automatically backported this PR to "29-x-y", please check out #41845

@trop trop bot added in-flight/29-x-y and removed target/29-x-y PR should also be added to the "29-x-y" branch. labels Apr 12, 2024
@trop
Copy link
Contributor

trop bot commented Apr 12, 2024

I have automatically backported this PR to "30-x-y", please check out #41846

@trop trop bot added in-flight/30-x-y merged/30-x-y PR was merged to the "30-x-y" branch. merged/29-x-y PR was merged to the "29-x-y" branch. and removed target/30-x-y PR should also be added to the "30-x-y" branch. in-flight/30-x-y in-flight/29-x-y labels Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/29-x-y PR was merged to the "29-x-y" branch. merged/30-x-y PR was merged to the "30-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants