Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 1 changes from 3-M124 #42091

Merged
merged 2 commits into from
May 8, 2024

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented May 8, 2024

electron/security#506 - c67f290ef0f0 from angle M124: GL: Sync unpack state for glCompressedTexSubImage3D

Unpack state is supposed to be ignored for compressed tex image calls
but some drivers use it anyways and read incorrect data.

Texture3DTestES3.PixelUnpackStateTexSubImage covers this case.

Bug: chromium:337766133
Change-Id: Ic11a056113b1850bd5b4d6840527164a12849a22
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5498735
Commit-Queue: Shahbaz Youssefi syoussefi@chromium.org
Reviewed-by: Shahbaz Youssefi syoussefi@chromium.org
(cherry picked from commit 1bb1ee061fe0bce322fb93b447a72e72c993a1f2)
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5518811
Commit-Queue: Srinivas Sista srinivassista@chromium.org
Reviewed-by: Srinivas Sista srinivassista@chromium.org

Notes:

@ppontes ppontes requested a review from a team as a code owner May 8, 2024 14:46
@ppontes ppontes added security 🔒 semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 28-x-y labels May 8, 2024
@VerteDinde VerteDinde merged commit 196b6e6 into 28-x-y May 8, 2024
13 checks passed
@VerteDinde VerteDinde deleted the cherry-pick/security/28-x-y/3-m124 branch May 8, 2024 21:36
Copy link

release-clerk bot commented May 8, 2024

Release Notes Persisted

  • Security: backported fix for CVE-2024-4558.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
28-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants