fix: restore non-panel focus behavior #42180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
added
target/30-x-y
MarshallOfSound
added
semver/patch
|
Fixes #42157 |
felixrieseberg
approved these changes
May 14, 2024
VerteDinde
approved these changes
May 14, 2024
|
Release Notes Persisted
|
This was referenced May 14, 2024
|
I have automatically backported this PR to "31-x-y", please check out #42186 |
trop
bot
added
in-flight/31-x-y
and removed
target/31-x-y
|
I have automatically backported this PR to "30-x-y", please check out #42187 |
trop
bot
added
in-flight/30-x-y
merged/30-x-y
|
Thank you for the quick fix! 🙏 |
MarshallOfSound
added a commit
that referenced
this pull request
May 28, 2024
The new activate API on macOS is pretty bad, we should just keep using the old API. Similar to #42180. Restores non-panel behavior to pre-panel support. Notes: BrowserWindow.show() now correctly restores focus to inactive apps on macOS
trop bot
added a commit
that referenced
this pull request
May 29, 2024
The new activate API on macOS is pretty bad, we should just keep using the old API. Similar to #42180. Restores non-panel behavior to pre-panel support. Notes: BrowserWindow.show() now correctly restores focus to inactive apps on macOS Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
trop bot
added a commit
that referenced
this pull request
May 29, 2024
The new activate API on macOS is pretty bad, we should just keep using the old API. Similar to #42180. Restores non-panel behavior to pre-panel support. Notes: BrowserWindow.show() now correctly restores focus to inactive apps on macOS Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
codebytere
pushed a commit
that referenced
this pull request
May 29, 2024
The new activate API on macOS is pretty bad, we should just keep using the old API. Similar to #42180. Restores non-panel behavior to pre-panel support. Notes: BrowserWindow.show() now correctly restores focus to inactive apps on macOS Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
VerteDinde
pushed a commit
that referenced
this pull request
May 29, 2024
The new activate API on macOS is pretty bad, we should just keep using the old API. Similar to #42180. Restores non-panel behavior to pre-panel support. Notes: BrowserWindow.show() now correctly restores focus to inactive apps on macOS Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue caused by the chain of #40307 and #41750
Fixes #42157
With the new "only run this on non-panels" logic we can restore the exact same old codepath.
Notes:
BrowserWindow.focus()now correctly restore focus to inactive apps on macOS