-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: remove fs-extra devdep #42533
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here fail to build. I think instead of refactoring bits here we should stick to the orginal code as much as possible (eg don't change async to sync).
Oh crud. I meant to delete a draft reply and instead deleted one of @jkleinsc's code review comments instead. Sorry about that, John. John's comment was that the new version of |
Apparently I am just drunk with power and should put the keyboard away for the night |
* build: remove fs-extra dependency from script/gen-filenames.ts * build: remove fs-extra dependency from script/spec-runner.js * build: remove fs-extra dependency from script/gn-asar.js * build: remove fs-extra dependency from spec/api-autoupdater-darwin-spec.ts * build: remove fs-extra dependency from spec/api-safe-storage-spec.ts * build: remove fs-extra dependency from spec/lib/codesign-helpers.ts * build: remove fs-extra dependency from spec/api-app-spec.ts * build: remove fs-extra dependency from spec/esm-spec.ts * build: remove fs-extra dependency from spec/lib/fs-helpers.ts * build: remove fs-extra dependency from spec/lib/api-shell-spec.ts * build: remove fs-extra dependency from spec/api-context-bridge-spec.ts * build: remove fs-extra dependency from spec/asar-integrity-spec.ts * build: remove fs-extra dependency from spec/node-spec.ts * build: remove fs-extra devdiv * fixup! build: remove fs-extra dependency from spec/api-context-bridge-spec.ts * fix: use force: true when removing directories * chore: reduce diffs to main
This comment was marked as outdated.
This comment was marked as outdated.
/trop run backport-to 31-x-y |
The backport process for this PR has been manually initiated - sending your PR to |
I have automatically backported this PR to "31-x-y", please check out #42708 |
/trop run backport-to 30-x-y |
The backport process for this PR has been manually initiated - sending your PR to |
I have automatically backported this PR to "30-x-y", please check out #42711 |
/trop run backport-to 32-x-y |
The backport process for this PR has been manually initiated - sending your PR to |
I have automatically backported this PR to "32-x-y", please check out #42712 |
Description of Change
Node 20's
fs
module does everything we need now -- particularly with{ recursive: true }
-- so we can drop ourfs-extra
dev dependency.I noticed this while tracking down an intermittent test failure in our downstream fork.
CC @codebytere
Checklist
npm test
passesRelease Notes
Notes: none.