docs: navigation history example #43889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
Co-authored-by: Alice Zhao <alice@makenotion.com>
Co-authored-by: Alice Zhao <alice@makenotion.com>
Co-authored-by: Alice Zhao <alice@makenotion.com>
Co-authored-by: Alice Zhao <alice@makenotion.com>
Co-authored-by: Alice Zhao <alice@makenotion.com>
Co-authored-by: Alice Zhao <alice@makenotion.com>
Co-authored-by: Alice Zhao <alice@makenotion.com>
Co-authored-by: Alice Zhao <alice@makenotion.com>
Co-authored-by: Alice Zhao <alice@makenotion.com>
Co-authored-by: Alice Zhao <alice@makenotion.com>
7 tasks
trop
bot
added
32-x-y
backport
ckerr
requested changes
Sep 23, 2024
There was a problem hiding this comment.
tutorial/navigation-history.md:46:35 - error TS2339: Property 'getAllEntries' does not exist on type 'NavigationHistory'.
This appears to be a valid error.
Unless #42014 gets backported -- and it currently has a do-not-backport label -- then it doesn't make sense to backport this part of the docs
Agreed! Thanks for the call out! My bad for not noticing the discrepancy in backport labels. Closing this PR! |
trop
bot
deleted the
trop/32-x-y-bp-docs-navigation-history-example-1727111913166
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #42980
See that PR for details.
Notes: none