protocol: respect requests from partition #4551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
force-pushed
the
protocol_session_patch
branch
from
7259f85
to
4ea2721
Compare
|
@zcbenz any clue about why this crash happens https://travis-ci.org/atom/electron/jobs/110389798 , just made a temp fix. Would like resolve the original cause. |
|
I don't think we need the
I think it is because calling |
deepak1556
force-pushed
the
protocol_session_patch
branch
from
a274803
to
0935362
Compare
|
Fixed, thanks! |
| const electron = require('electron'); | ||
| const app = electron.app; | ||
| const path = require('path'); | ||
| const protocol = session.fromPartition(partitionName).protocol; |
There was a problem hiding this comment.
Creating session before the ready event is not recommended, for now it is causing crash on exit.
deepak1556
force-pushed
the
protocol_session_patch
branch
from
0935362
to
bdfc19a
Compare
|
👍 |
zcbenz
added a commit
that referenced
this pull request
Feb 24, 2016
protocol: respect requests from partition
Merged
zcbenz
added a commit
that referenced
this pull request
Feb 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protocol module currently doesnt respect partitions. This just adds a
fromPartitionmethod similar tosession, internallyprotocolis now wired as a property ofsession.