New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create user_data_dir before creating singleton lock #5311

Merged
merged 1 commit into from Apr 27, 2016

Conversation

Projects
None yet
2 participants
@zcbenz
Contributor

zcbenz commented Apr 27, 2016

Because of #5237, there is no guarantee that the user_data_dir is always created, so we need to make sure it exists when calling app.makeSingleInstance.

Close #5277.

@zcbenz zcbenz merged commit 0fa9292 into master Apr 27, 2016

8 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3131380 succeeded in 35s
Details
electron-linux-ia32 Build #3131381 succeeded in 31s
Details
electron-linux-x64 Build #3131382 succeeded in 59s
Details
electron-mas-x64 Build #976 succeeded in 5 min 41 sec
Details
electron-osx-x64 Build #987 succeeded in 6 min 16 sec
Details
electron-win-ia32 Build #3131383 succeeded in 47s
Details
electron-win-x64 Build #3131384 succeeded in 50s
Details

@zcbenz zcbenz deleted the fix-singleton branch Apr 27, 2016

@baconbrad

This comment has been minimized.

Contributor

baconbrad commented Apr 29, 2016

On the releases page "Disable node integration in webview when it is disabled in host page." links to this PR. I think it meant to reference PR 5244.

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Apr 30, 2016

@baconface You are right, thanks for heading up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment