Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when using fetch in custom protocols #5932

Merged
merged 4 commits into from Jun 8, 2016
Merged

Fix crash when using fetch in custom protocols #5932

merged 4 commits into from Jun 8, 2016

Commits on Jun 8, 2016

  1. spec: Custom protocol can have "fetch" working in it

    @zcbenz
    zcbenz committed Jun 8, 2016
    Copy the full SHA
    1146b2d View commit details
    Browse the repository at this point in the history

  2. Make sure standard schemes are also set in child process

    @zcbenz
    zcbenz committed Jun 8, 2016
    Copy the full SHA
    920ebee View commit details
    Browse the repository at this point in the history

  3. Mark standard scheme as safe scheme

    @zcbenz
    zcbenz committed Jun 8, 2016
    Copy the full SHA
    7108cc5 View commit details
    Browse the repository at this point in the history

  4. Don't rely on AddAdditionalSchemes for setting standard schemes 

    On Linux because of the existence of zygote process, it becomes very
tricky to correctly set standard schemes, basically we have to:
1. Pass --standard-schemes to both zygote and render processes
2. Init standard schemes for both zygote and render processes

The )1 is very hard to achieve, so instead of using
AddAdditionalSchemes, we just call url::AddStandardScheme directly.
    @zcbenz
    zcbenz committed Jun 8, 2016
    Copy the full SHA
    1bfbd21 View commit details
    Browse the repository at this point in the history