New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The fullscreen button should always be hidden for frameless window #6433

Merged
merged 1 commit into from Jul 11, 2016

Conversation

Projects
None yet
1 participant
@zcbenz
Contributor

zcbenz commented Jul 11, 2016

The fullscreen button is a OS X 10.9 only thing, and we don't want to have it under frameless window. We actually had this patch at first, but it got removed some time later, probably when we introduced the titleBarStyle option.

Close #6227.

@zcbenz zcbenz merged commit 70a29bd into master Jul 11, 2016

7 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #3628849 succeeded in 41s
Details
electron-linux-ia32 Build #3628850 succeeded in 37s
Details
electron-linux-x64 Build #3628851 succeeded in 73s
Details
electron-mas-x64 Build #1868 succeeded in 5 min 55 sec
Details
electron-osx-x64 Build #1875 succeeded in 7 min 17 sec
Details
electron-win-ia32 Build #876 succeeded in 6 min 25 sec
Details
electron-win-x64 Build #866 succeeded in 6 min 27 sec
Details

@zcbenz zcbenz deleted the fullscreen-button branch Jul 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment