Add BrowserWindow.prototype.setThumbnailToolTip #6762
Conversation
| @@ -858,6 +864,7 @@ void Window::BuildPrototype(v8::Isolate* isolate, | |||
| .SetMethod("unhookWindowMessage", &Window::UnhookWindowMessage) | |||
| .SetMethod("unhookAllWindowMessages", &Window::UnhookAllWindowMessages) | |||
| .SetMethod("setThumbnailClip", &Window::SetThumbnailClip) | |||
| .SetMethod("setThumbnailTooltip", &Window::SetThumbnailTooltip) | |||
There was a problem hiding this comment.
The method on Tray is called setToolTip so I wonder if this should be setThumbnailToolTip for consistency.
There was a problem hiding this comment.
@kevinsawicki Was referring to capitalizing (the second T in ToolTip) "setThumbnailToolTip"
There was a problem hiding this comment.
I guess it's too late... (should go to sleep already) I haven't read his comment properly :)
Renamed to setThumbnailToolTip, even though I don't like it much, as I think tooltip is a single word.
There was a problem hiding this comment.
I've also just noticed that the branch name is incorrect :)
There was a problem hiding this comment.
@miniak As is the MSDN link at the top of the PR, but what's a link and a branch name between friends 😆
miniak
changed the title
| @@ -667,6 +667,12 @@ bool Window::SetThumbnailClip(const gfx::Rect& region) { | |||
| return window->taskbar_host().SetThumbnailClip( | |||
| window_->GetAcceleratedWidget(), region); | |||
| } | |||
|
|
|||
| bool Window::SetThumbnailToolTip(const std::string& tooltip) { | |||
There was a problem hiding this comment.
We can pass const base::string16& directly here, which is more efficient than converting std::string to UTF16 later.
There was a problem hiding this comment.
The other methods also take std::string, I can create another PR to refactor all of them.
https://msdn.microsoft.com/en-us/library/windows/desktop/dd391702(v=vs.85).aspx