Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't serialize external values over IPC #6998

Merged
merged 12 commits into from
Aug 31, 2016
Merged

Don't serialize external values over IPC #6998

merged 12 commits into from
Aug 31, 2016

Commits on Aug 29, 2016

  1. Don't convert values with internal fields

    @kevinsawicki
    kevinsawicki committed Aug 29, 2016
    Configuration menu
    Copy the full SHA
    4579ec6 View commit details
    Browse the repository at this point in the history

  2. Convert specs to expect empty objects

    @kevinsawicki
    kevinsawicki committed Aug 29, 2016
    Configuration menu
    Copy the full SHA
    3f4af3a View commit details
    Browse the repository at this point in the history

  3. Add regression spec for HTTP request over IPC

    @kevinsawicki
    kevinsawicki committed Aug 29, 2016
    Configuration menu
    Copy the full SHA
    e38bc17 View commit details
    Browse the repository at this point in the history

  4. Add empty request error handler

    @kevinsawicki
    kevinsawicki committed Aug 29, 2016
    Configuration menu
    Copy the full SHA
    b17a287 View commit details
    Browse the repository at this point in the history

  5. Ignore external values when serializing

    @kevinsawicki
    kevinsawicki committed Aug 29, 2016
    Configuration menu
    Copy the full SHA
    58fc1b7 View commit details
    Browse the repository at this point in the history

  6. Re-enable DOM object over IPC asserts

    @kevinsawicki
    kevinsawicki committed Aug 29, 2016
    Configuration menu
    Copy the full SHA
    0f7e43a View commit details
    Browse the repository at this point in the history

  7. Add test for sending webContents instance over IPC

    @kevinsawicki
    kevinsawicki committed Aug 29, 2016
    Configuration menu
    Copy the full SHA
    434e7cb View commit details
    Browse the repository at this point in the history

  8. Add explicit test for IPC cycle detection

    @kevinsawicki
    kevinsawicki committed Aug 29, 2016
    Configuration menu
    Copy the full SHA
    558ee08 View commit details
    Browse the repository at this point in the history

  9. 🎨

    @kevinsawicki
    kevinsawicki committed Aug 29, 2016
    Configuration menu
    Copy the full SHA
    625bfe5 View commit details
    Browse the repository at this point in the history

  10. Explicitly mention external objects

    @kevinsawicki
    kevinsawicki committed Aug 29, 2016
    Configuration menu
    Copy the full SHA
    679ee95 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2016

  1. Move IsExternal check to FromV8ValueImpl

    @kevinsawicki
    kevinsawicki committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    8a9776b View commit details
    Browse the repository at this point in the history

  2. Test external value as send argument

    @kevinsawicki
    kevinsawicki committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    3e7a0e4 View commit details
    Browse the repository at this point in the history