Fixes mouse coordinates for Windows when display is set to a higher DPI #7362

Merged
merged 1 commit into from Sep 28, 2016

Projects

None yet

3 participants

@bsclifton
Member

Fixes mouse coordinates for Windows when display is set to a higher DPI (ex: enlarged by 150% using display settings)

Draggability was being impacted when display settings were bumped up. The wrong coordinates would be considered for the hit testing.

Fixes #7347

@bsclifton bsclifton Fixes mouse coordinates for Windows when display is set to a higher D…
…PI (ex: enlarged by 150% using display settings)
13de65d
@zcbenz
Contributor
zcbenz commented Sep 28, 2016

👍

@zcbenz zcbenz merged commit c51982a into electron:master Sep 28, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MarshallOfSound
Member

@bsclifton @zcbenz I think this has broken mouse position inside a webview element.

My app currently has an issue where the mouse point would stutter all over the place in a webview (seemingly in multiple places at once)

If you read this issue thread from this comment down https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/issues/1777#issuecomment-258508372

You can see that users disabling display scaling fix the issue. This PR seems to correspond with the version jump that caused the issue. Any thoughts on whether this is the cause?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment