Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes mouse coordinates for Windows when display is set to a higher DPI #7362

Merged
merged 1 commit into from Sep 28, 2016
Merged

Fixes mouse coordinates for Windows when display is set to a higher DPI #7362

merged 1 commit into from Sep 28, 2016

Conversation

bsclifton
Copy link
Contributor

Fixes mouse coordinates for Windows when display is set to a higher DPI (ex: enlarged by 150% using display settings)

Draggability was being impacted when display settings were bumped up. The wrong coordinates would be considered for the hit testing.

Fixes #7347

…PI (ex: enlarged by 150% using display settings)
@zcbenz
Copy link
Member

zcbenz commented Sep 28, 2016

👍

@MarshallOfSound
Copy link
Member

@bsclifton @zcbenz I think this has broken mouse position inside a webview element.

My app currently has an issue where the mouse point would stutter all over the place in a webview (seemingly in multiple places at once)

If you read this issue thread from this comment down MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-#1777 (comment)

You can see that users disabling display scaling fix the issue. This PR seems to correspond with the version jump that caused the issue. Any thoughts on whether this is the cause?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants