New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus window on menu bar click #7707

Merged
merged 1 commit into from Oct 25, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Oct 24, 2016

This pull request reverts #7468 and instead just explicitly focuses the window when a menu bar button is clicked so that the original issue (#7282) is still addressed and the menu items are targeting the right window.

Previously focusing the menu bar caused the web contents to lose focus meaning input fields or the dev tools would not regain focus after the menu was closed.

Closes #7663

@zcbenz

This comment has been minimized.

Show comment
Hide comment
@zcbenz

zcbenz Oct 25, 2016

Contributor

👍

Contributor

zcbenz commented Oct 25, 2016

👍

@zcbenz zcbenz merged commit 775328d into master Oct 25, 2016

8 of 9 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #4500933 succeeded in 62s
Details
electron-linux-ia32 Build #4500934 succeeded in 57s
Details
electron-linux-x64 Build #4500935 succeeded in 114s
Details
electron-mas-x64 Build #2656 succeeded in 8 min 23 sec
Details
electron-osx-x64 Build #2668 succeeded in 8 min 44 sec
Details
electron-win-ia32 Build #1750 succeeded in 8 min 4 sec
Details
electron-win-x64 Build #1722 succeeded in 8 min 12 sec
Details

@zcbenz zcbenz deleted the focus-window-on-menu-bar-click branch Oct 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment