Add sheet-begin and sheet-end events to macOS BrowserWindow #9108
Conversation
spec/api-browser-window-spec.js
Outdated
| @@ -1191,6 +1191,41 @@ describe('BrowserWindow module', function () { | |||
| }) | |||
| }) | |||
|
|
|||
| describe('begin-sheet event', function (done) { | |||
There was a problem hiding this comment.
This shouldn't take a done callback, the it function should.
There was a problem hiding this comment.
I didn't notice the mistake, thanks!
spec/api-browser-window-spec.js
Outdated
| }) | ||
| }) | ||
|
|
||
| describe('end-sheet event', function (done) { |
There was a problem hiding this comment.
This shouldn't take a done callback, the it function should
spec/api-browser-window-spec.js
Outdated
| return | ||
| } | ||
| it('emits when window opens a sheet', function () { | ||
| let sheet |
There was a problem hiding this comment.
This should be a variable declared at the root describe level and this window should be cleaned up in an afterEach to make sure it does not stick around.
afterEach(function () {
return closeWindow(sheet).then(function () { sheet = null })
})
docs/api/browser-window.md
Outdated
| @@ -498,6 +498,14 @@ Returns: | |||
|
|
|||
| Emitted on 3-finger swipe. Possible directions are `up`, `right`, `down`, `left`. | |||
|
|
|||
| #### Event: 'begin-sheet' _macOS_ | |||
There was a problem hiding this comment.
What do you think about calling these sheet-begin and sheet-end instead?
Then they would follow the naming pattern of the scroll-touch-* events.
There was a problem hiding this comment.
I agree. I was not able to decide because there is also the pattern of *-full-screen events.
yuya-oc
force-pushed
the
add-macos-sheet-events
branch
from
3654406
to
7518404
Compare
yuya-oc
changed the title
|
Updated. Now |
|
Thanks for this @yuya-oc 👍 🚀 |
These would be helpful when a dialog is opened without using BrowserWindow's
modaloption ordialogmodule.For example, when a dialog is opened by
<input type="file">of a webview, the webview loses focus after the dialog is closed. This new event can tell that the dialog has been closed in order to get focus again.