New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sheet-begin and sheet-end events to macOS BrowserWindow #9108

Merged
merged 2 commits into from Apr 20, 2017

Conversation

Projects
None yet
2 participants
@yuya-oc
Contributor

yuya-oc commented Apr 4, 2017

These would be helpful when a dialog is opened without using BrowserWindow's modal option or dialog module.

For example, when a dialog is opened by <input type="file"> of a webview, the webview loses focus after the dialog is closed. This new event can tell that the dialog has been closed in order to get focus again.

@kevinsawicki

Left a few minor comments, thanks for adding this 👍

Show outdated Hide outdated spec/api-browser-window-spec.js
Show outdated Hide outdated spec/api-browser-window-spec.js
Show outdated Hide outdated spec/api-browser-window-spec.js
Show outdated Hide outdated docs/api/browser-window.md

@kevinsawicki kevinsawicki self-assigned this Apr 11, 2017

@yuya-oc yuya-oc changed the title from Add begin-sheet and end-sheet events to macOS BrowserWindow to Add sheet-begin and sheet-end events to macOS BrowserWindow Apr 15, 2017

@yuya-oc

This comment has been minimized.

Show comment
Hide comment
@yuya-oc

yuya-oc Apr 16, 2017

Contributor

Updated. Now sheet-begin and sheet-end events would be emitted.

Contributor

yuya-oc commented Apr 16, 2017

Updated. Now sheet-begin and sheet-end events would be emitted.

@kevinsawicki kevinsawicki merged commit dc8b439 into electron:master Apr 20, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Apr 20, 2017

Contributor

Thanks for this @yuya-oc 👍 🚀

Contributor

kevinsawicki commented Apr 20, 2017

Thanks for this @yuya-oc 👍 🚀

@yuya-oc yuya-oc deleted the yuya-oc:add-macos-sheet-events branch Apr 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment