New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printing on Windows #9111

Merged
merged 2 commits into from Apr 5, 2017

Conversation

Projects
None yet
3 participants
@kevinsawicki
Contributor

kevinsawicki commented Apr 5, 2017

  • Restore the delivering of IPC messages to utility handlers that regressed in #8501
  • Port upstream page printing bug from #9044

Closes #8489
Closes #8828

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Apr 5, 2017

Contributor

/cc @rreimann would you be able to build and test this branch to make sure it includes the selected pages fix?

Contributor

kevinsawicki commented Apr 5, 2017

/cc @rreimann would you be able to build and test this branch to make sure it includes the selected pages fix?

@rreimann

This comment has been minimized.

Show comment
Hide comment
@rreimann

rreimann Apr 5, 2017

Contributor

/cc @rreimann would you be able to build and test this branch to make sure it includes the selected pages fix?

@kevinsawicki i've tested the branch. The fix is included - printing selected pages works 👍

Contributor

rreimann commented Apr 5, 2017

/cc @rreimann would you be able to build and test this branch to make sure it includes the selected pages fix?

@kevinsawicki i've tested the branch. The fix is included - printing selected pages works 👍

@hokein

hokein approved these changes Apr 5, 2017

LGTM.

@kevinsawicki kevinsawicki merged commit d857b71 into master Apr 5, 2017

8 of 9 checks passed

electron-win-x64 Build #2786 failed in 11 min
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #6115893 succeeded in 73s
Details
electron-linux-ia32 Build #6115894 succeeded in 66s
Details
electron-linux-x64 Build #6115895 succeeded in 151s
Details
electron-mas-x64 Build #3826 succeeded in 8 min 27 sec
Details
electron-osx-x64 Build #3821 succeeded in 9 min 0 sec
Details
electron-win-ia32 Build #2813 succeeded in 8 min 11 sec
Details

@kevinsawicki kevinsawicki deleted the deliver-ipc-messages-to-handlers branch Apr 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment