Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix printing on Windows #9111

Merged
merged 2 commits into from Apr 5, 2017
Merged

Fix printing on Windows #9111

merged 2 commits into from Apr 5, 2017

Conversation

kevinsawicki
Copy link
Contributor

@kevinsawicki kevinsawicki commented Apr 5, 2017 •
edited

Closes #8489
Closes #8828

@kevinsawicki
Copy link
Contributor Author

kevinsawicki commented Apr 5, 2017 •
edited

/cc @rreimann would you be able to build and test this branch to make sure it includes the selected pages fix?

@kevinsawicki kevinsawicki mentioned this pull request Apr 5, 2017
Closed
@rreimann
Copy link
Contributor

rreimann commented Apr 5, 2017

/cc @rreimann would you be able to build and test this branch to make sure it includes the selected pages fix?

@kevinsawicki i've tested the branch. The fix is included - printing selected pages works 👍

@kevinsawicki kevinsawicki requested a review from hokein April 5, 2017 15:42
@kevinsawicki kevinsawicki mentioned this pull request Apr 5, 2017
Merged
hokein
hokein approved these changes Apr 5, 2017
View reviewed changes
Copy link
Contributor

@hokein hokein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kevinsawicki kevinsawicki merged commit d857b71 into master Apr 5, 2017
@kevinsawicki kevinsawicki deleted the deliver-ipc-messages-to-handlers branch April 5, 2017 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hokein hokein hokein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevinsawicki @rreimann @hokein