-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(forge): introduce webpack plugin and remove parcel #1109
Conversation
9cf5ff4
to
033d13e
Compare
033d13e
to
0f2e630
Compare
f52f217
to
67b88b6
Compare
67b88b6
to
d2aa769
Compare
64503c7
to
31d3050
Compare
31d3050
to
fbb6167
Compare
fbb6167
to
fb153ca
Compare
32791e3
to
0ce9fb9
Compare
2a3c793
to
04a0eb0
Compare
07a3cbe
to
6c21704
Compare
Co-authored-by: David Sanders <dsanders11@ucsbalum.com> Co-authored-by: Felix Rieseberg <felix@felixrieseberg.com> Co-authored-by: BlackHole1 <158blackhole@gmail.com>
6c21704
to
b5388f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for working through all the issues here. 🙂
- name: Create fake contributors | ||
uses: 1arp/create-a-file-action@0.2 | ||
with: | ||
path: 'static' | ||
file: 'contributors.json' | ||
content: "[]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just adding a note here to investigate why tests/globalSetup.js
doesn't work for CI for creating this file. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
Introduces forge+webpack configuration and removes parcel for the bundling process.
Errors
Active
None
Fixed
Logs from terminal- (Resolved ✅)Figure out how to stop the browser tabs from opening when application is hot reloaded. (webpack-dev-server) - This is opening like 2-3 tabs for me for each reload which is kinda getting on the nerves now. (To be fixed by build: upgrade to Forge 6.0.0-beta.64 #1119)(Resolved ✅)(Resolved ✅)yarn make
stops with - (To be fixed by build: upgrade to Forge 6.0.0-beta.64 #1119)for all packages.
When the application is stopped, forge throws an error saying - (To be fixed by build: upgrade to Forge 6.0.0-beta.64 #1119)(Resolved ✅)Figure out the best way to handles assets.(Resolved ✅)Fonts not being read and rendered properly.(Resolved ✅)CSP is blocking some requests- (Resolved ✅)Failing jest tests- (Resolved ✅)