Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use Node v16.x for GitHub actions #1117

Merged
merged 1 commit into from
Jun 24, 2022
Merged

chore: use Node v16.x for GitHub actions #1117

merged 1 commit into from
Jun 24, 2022

Conversation

dsanders11
Copy link
Member

@dsanders11 dsanders11 commented Jun 23, 2022 •
edited
Loading

Switch to the current Node LTS, newer packages don't support back to 12.x anymore.

This popped out of #1109.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.125% when pulling f676675 on dsanders11:node-v16 into a8862e1 on electron:main.

@dsanders11 dsanders11 marked this pull request as ready for review June 23, 2022 17:23
@dsanders11 dsanders11 requested review from codebytere and a team June 23, 2022 17:24
@dsanders11 dsanders11 merged commit 7d5241b into electron:main Jun 24, 2022
@dsanders11 dsanders11 deleted the node-v16 branch June 24, 2022 05:21
@dsanders11 dsanders11 mentioned this pull request Jun 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlackHole1 BlackHole1 BlackHole1 approved these changes

@codebytere codebytere Awaiting requested review from codebytere codebytere is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dsanders11 @coveralls @BlackHole1