build: enforce sort-imports eslint rule #1147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
sort-import
rule in codebase.Summary -
eslint --fix
. Hence, this is whereeslint-plugin-import
helps us! (It also provides better control on how imports are sorted)eslint-import-resolver-typescript
to resolve imports in typescript files.lint:js
which sort the imports in.js
files.yarn lint
which autofixes all the problems for us :)Rules kept off -
Edit: This can be merged once large pending pull requests are merged first - to avoid large merge conflicts :)