Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: don't use shell.openExternal in renderer #1260

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

dsanders11
Copy link
Member

All window.open calls are already denied and opened by shell.openExternal by default via setWindowOpenHandler, so shell.openExternal doesn't need to be used in the renderer.

browserWindow.webContents.setWindowOpenHandler((details) => {
shell.openExternal(details.url);
return { action: 'deny' };
});

@dsanders11 dsanders11 requested a review from a team as a code owner February 8, 2023 06:01
@coveralls
Copy link

Coverage Status

Coverage: 91.379% (-0.004%) from 91.382% when pulling 9044272 on dsanders11:contributors-open into ff0de26 on electron:main.

@dsanders11 dsanders11 merged commit cabe345 into electron:main Feb 8, 2023
@dsanders11 dsanders11 deleted the contributors-open branch February 8, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants