feat: enable opening external URLs in editor #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
enable-open-external
branch
from
4855a9d
to
abf0bc7
Compare
erikian
approved these changes
Jan 5, 2024
dsanders11
reviewed
Jan 5, 2024
There was a problem hiding this comment.
Do we need to add the IPC call? I think we can just use window.open in this case, see #1260.
|
@dsanders11 good call - changed! |
dsanders11
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1523.
Fixes an issue where external links did not function properly. The user can now open external links after confirming the link to open (for security purposes).