build: replace TSLint with ESLint and Prettier #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzhao
changed the title
erickzhao
force-pushed
the
erick/prettier
branch
from
9f7e586
to
e49cb57
Compare
erickzhao
force-pushed
the
erick/prettier
branch
from
e49cb57
to
ad0b9f3
Compare
malept
reviewed
Jul 24, 2020
malept
reviewed
Aug 1, 2020
malept
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #206
We've been wanting to move from TSLint to ESLint and Prettier for a while. The maintainers of TSLint deprecated the package last year (palantir/tslint#4534), so this is a good time to transition.
I tried to adapt our previous TSLint config to match the new ESLint one as much as possible, but tried to keep it close to the default Prettier settings as well.
Note that this PR also adds
lint-stagedandhuskyfor pre-commit hook linting.