Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publisher-electron-release-server): set knownLength option for asset upload #2706

Conversation

monsterkrampe
Copy link
Contributor

closes: #2087

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
Resubmitting #2088 after rebasing.

@monsterkrampe monsterkrampe force-pushed the bugfix/publisher-electron-release-server-filesize-missing-2087 branch from f889f30 to 01b8b43 Compare February 5, 2022 09:42
@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #2706 (7be09a2) into master (204ec25) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2706      +/-   ##
==========================================
- Coverage   74.06%   74.03%   -0.04%     
==========================================
  Files          77       77              
  Lines        2356     2357       +1     
  Branches      436      436              
==========================================
  Hits         1745     1745              
- Misses        462      463       +1     
  Partials      149      149              
Impacted Files Coverage Δ
...lisher/electron-release-server/src/PublisherERS.ts 26.86% <0.00%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 204ec25...7be09a2. Read the comment docs.

@monsterkrampe monsterkrampe force-pushed the bugfix/publisher-electron-release-server-filesize-missing-2087 branch from 01b8b43 to 7be09a2 Compare March 2, 2022 08:58
@monsterkrampe
Copy link
Contributor Author

Hi @MarshallOfSound,
I just rebased this PR again to make the tests pass.
The changes should be the same as in #2088 so I hope that this is now ready to be merged :)

@VerteDinde VerteDinde merged commit cf08cd6 into electron:master Apr 19, 2022
@monsterkrampe
Copy link
Contributor Author

Thanks!
I'm very glad to finally see this merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publisher-Electron-Release-Server: Asset Upload fails with 400 Bad Request (file size seems to be missing)
3 participants