Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publisher-electron-release-server): set knownLength option for asset upload #2088

Conversation

monsterkrampe
Copy link
Contributor

closes: #2087

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
As mentioned in the README of the form-data package (see also form-data/form-data#426), the knownLength option is now set for the asset upload in the Publisher Electron Release Server.

Note that the issue may affect other publishers in a similar way (but I did not check this).

@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #2088 (2916e49) into master (286f96a) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2088      +/-   ##
==========================================
- Coverage   72.71%   72.68%   -0.04%     
==========================================
  Files          74       74              
  Lines        2221     2222       +1     
  Branches      420      420              
==========================================
  Hits         1615     1615              
- Misses        446      447       +1     
  Partials      160      160              
Impacted Files Coverage Δ
...lisher/electron-release-server/src/PublisherERS.ts 26.86% <0.00%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 286f96a...2916e49. Read the comment docs.

@monsterkrampe
Copy link
Contributor Author

monsterkrampe commented Dec 14, 2020

The changed section was not covered by tests before which is reasonable for this particular method in my opinion. So personally I would not consider the coverage a real issue here.

@MarshallOfSound
Copy link
Member

Closing due to conflicts, someone can use this as prior art to issue a new fix

@monsterkrampe
Copy link
Contributor Author

I'll resolve the conflicts as soon as possible :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publisher-Electron-Release-Server: Asset Upload fails with 400 Bad Request (file size seems to be missing)
2 participants