Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add needed Vite infra details #3197

Merged
merged 1 commit into from
Mar 28, 2023
Merged

chore: add needed Vite infra details #3197

merged 1 commit into from
Mar 28, 2023

Conversation

VerteDinde
Copy link
Member

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

In 6.1.0, you cannot create a new Vite template with create-electron-app, because we did not include the needed packages in dependencies. This PR adds the needed dependency to @electron-forge/core.

@VerteDinde VerteDinde requested a review from a team March 28, 2023 23:12
@VerteDinde VerteDinde requested a review from a team as a code owner March 28, 2023 23:12
@georgexu99 georgexu99 merged commit 1cb2f99 into main Mar 28, 2023
@georgexu99 georgexu99 deleted the fix-vite-resolutions branch March 28, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants