-
-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: align test save location configs #3585
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's still having trouble with Windows.
Thank you for this! |
I just merged main with no additional changes to the previous, and surprisingly filename timings across all platforms were detected. This makes me think that the timing detection issue we saw on the previous slow Windows CI run wasn't caused by outputting OS incompatible relative paths. My theory right now is that the path detection relies on testing output from previous circle runs. I wish I could ssh into the circle testing machines to confirm the content of the test folder and get a better mental model, but it looks like Rerun with SSH is disabled. I want to confirm the following:
|
Closing this PR, as I feel like I'm spinning my wheels to no avail. Based on my hypothesis from the comment above, I want to conclude that filename timing detection is not actually broken on main since 1a and 1b's circle runs both have timings detected, despite not making any changes to the existing logic for making the test report paths relative. However, this run that happened recently seems to suggest otherwise for slow windows tests. Moreover, how would 1a have timings detected when I changed the output location to a path that's never been used and shouldn't have any existing files? Perplexing |
Revived PR here: #3620 |
Summarize your changes:
CircleCI can't detect previous test timing data. Fixing this by tweaking the script we use to ensure filepaths in the junit xml files are using relative paths
Testing:
CI=1 yarn test --suite="slow"