V6 API #433
V6 API #433
Conversation
|
Git's diff isn't smart enough to realize but not much code has changed here, lot's of this is just transposition |
.travis.yml
Outdated
| install: | ||
| - npm install | ||
| - npm update | ||
| - npm i -g bolt |
There was a problem hiding this comment.
Does it have to be installed globally?
| @@ -0,0 +1 @@ | |||
| 8.9.1 | |||
There was a problem hiding this comment.
Is this necessary to be committed to the repo?
There was a problem hiding this comment.
Not required, but helpful for most macOS / *nix users who use nvm (it will auto-select the node version).
There was a problem hiding this comment.
It's kind of odd that it's Node 8 when the minimum version is Node 6.
There was a problem hiding this comment.
Recommend Dev version, not version required for using
| fakeMake('darwin').reduce((accum, val) => accum.concat(val.artifacts), []).sort() | ||
| ); | ||
| expect(darwinArgs.packageJSON).to.deep.equal({ state: 1 }); | ||
| expect(darwinArgs.authToken).to.equal(undefined); | ||
| expect(darwinArgs.tag).to.equal(null); | ||
| expect(darwinArgs.tag).to.equal('1.0.0'); |
There was a problem hiding this comment.
@MarshallOfSound I'm not sure about this change I made to get the publisher tests working, let me know if this is incorrect.
|
I think boltpkg/bolt#154 blocks the Windows tests from passing. |
|
That bolt PR has been merged, waiting for it to be in a new release ⏳ |
* Allow absolute paths to custom modules * Update to new @electron-forge/ scope
tabtab is rather buggy and the alternative, commander-completion, needs a custom completion script to be written and maintained.
|
When we merge this I'm going to release all the modules on npm as Future releases will all have the same version number to make tracking easier. I.e. Changing something in one module will result in new versions of all modules. We will only officially support the case where you all your forge dependencies are the same version. |
|
As soon as this goes green I'm gonna merge it, will do add docs over time but want to get at least a beta out there so I can start using it 😀 |
This is still WIP but I thought I'd put a PR up so people can easily see the diff 😄