fix(publisher): call resolve() when electron-release-server publisher succeeds #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… succeeds ISSUES CLOSED: #460
|
The only reason this worked is on some node versions once the event loop is empty node exits, however, some node versions consider hanging promises still active on the event loop |
malept
added a commit
that referenced
this pull request
Apr 4, 2018
… succeeds This is a backport of #465 to the 5.x series.
5 tasks
malept
added a commit
that referenced
this pull request
Apr 4, 2018
… succeeds This is a backport of #465 to the 5.x series.
MarshallOfSound
added a commit
that referenced
this pull request
Apr 11, 2018
* temp * Start working in new package structure * Example maker * All makers implemented and tests passing on darwin * Add v6 branches to travis config * Add v6 branches to appveyor config * Gitignore _old * Remove FIXME comments * Remove from CI branch whitelist * Install bolt on docker * Add to whitelist * Fix bolt usage on CI * Run bolt build on CI * Fix tests on CI * Fix linting * Fix CI * Make publishers work and add specs * Docs template * Initial docs * update plugin interface to support resolving strings * more docs * add deps and scripts * send makeResults instead of flatten artifacts list * feat(publisher): Allow to configure channel for ERS (#456) * fix(publisher): call resolve() when electron-release-server publisher succeeds (#465) ISSUES CLOSED: #460 * Fix publisher tests * Remove stray console statement * v6-api is a PR now, no need to explicitly add to CI * Add top level license * Change Maker/Publisher syntax so that they can be constructed with a config variable * Fix custom init * Allow absolute paths to custom modules * Update to new @electron-forge/ scope * Add missing semi * Use absolute path for custom init to avoid runnig npm link on windows * Fix appx test reference to fixture key file * Remove shell completion support (#447) tabtab is rather buggy and the alternative, commander-completion, needs a custom completion script to be written and maintained. * install new beta tagged bolt on CI * Fix testing snap building in Travis * fix remove error * Fix config passing in tests * fix search order
dsanders11
pushed a commit
that referenced
this pull request
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
This should probably be backported to 5.x too.
ISSUES CLOSED: #460