feat: add initializeProxy helper for downstream packages #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems reasonable. Not sure how we'd handle this in Fiddle, though. |
|
@malept Fiddle being gui / non-cli would just expose something in settings for this 👍 |
|
@MarshallOfSound Can this be approved? |
MarshallOfSound
approved these changes
Oct 26, 2019
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Folks are having trouble with using this module behind corporate proxies (example: electron/packager#1019). This pull request adds a method (code borrowed from yeoman) that will add environment variable support. See the new section of the README for details.
Downstream packages I expect to provide PRs for, if this is merged:
electronelectron-packager@electron-forge/clifiddle, I think?https://electronjs.org/docs/tutorial/installation#proxies will have to be modified slightly once
electron/electronis updated (not that it's accurate right now anyway...)