Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: copy playbooks from electron/maintainers #9

Merged
merged 3 commits into from
Mar 1, 2019
Merged

Conversation

ckerr
Copy link
Member

@ckerr ckerr commented Feb 26, 2019

Does what it says on the tin -- this is a cp -R + git -A to bring the playbooks into the governance repo.

@@ -0,0 +1,46 @@
# Security Incidents
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not copy this over verbatim, it's an action item of the Secutity WG to develop an new play for this taking into account our new structure and permission model

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on modifying those rules to take governance into account, but since the playbook includes a lot besides security, IMO it would be slightly cleaner to write / refine those rules in a separate PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry if that wasn't clear, I was specifically referring to just this document not all the playbooks. It's currently just wrong about a lot of things (especially taking into account our new structure). This document also doesn't accurately reflect the way things are done currently.

I have a draft PR for electron/security (that will end up in this repo under wg-security once merged approved in /security) for what our disclosure policy / response procedure will be.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed security-incidents.md.

NB the Security Incidents in playbooks/README.md now has a FIXME link for the document you're working on. Please update this link when your PR gets merged.

@ckerr ckerr merged commit 275e35d into master Mar 1, 2019
@ckerr ckerr deleted the add-playbooks branch March 1, 2019 23:27
@ckerr ckerr mentioned this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants