Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Commit

Permalink
Merge pull request #760 from electron/fix-mksnapshot-v8-flags
Browse files Browse the repository at this point in the history
fix: include v8 flags used by electron in ffmpeg build
  • Loading branch information
John Kleinschmidt committed May 23, 2019
2 parents 83fd716 + d84bd5a commit 55625e1
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions chromiumcontent/args/ffmpeg.gn
Expand Up @@ -16,6 +16,16 @@ if (target_os != "linux") {
# https://chromium.googlesource.com/chromium/src/+/master/docs/jumbo.md
use_jumbo_build = true

# This is required by Node.js
# See https://github.com/nodejs/node/pull/13242
v8_promise_internal_field_count = 1

# This is required by Node.js
# Unconditionally force typed arrays to allocate outside the v8 heap. This
# is to prevent memory pointers from being moved around that are returned by
# Buffer::Data()
v8_typed_array_max_size_in_heap = 0

if (target_cpu == "arm64") {
# Suppress the linking warning for arm64:
# warning: libfreetype.so.6, needed by ../../build/linux/debian_jessie_arm64-sysroot/usr/lib/aarch64-linux-gnu/libfontconfig.so, may conflict with libfreetype.so.6
Expand Down

0 comments on commit 55625e1

Please sign in to comment.