Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Fix for webviews using default (empty) BeginFrameSubscription implementation #227

Merged
merged 1 commit into from
Sep 1, 2016

Conversation

brenca
Copy link
Contributor

@brenca brenca commented Aug 30, 2016

This PR adds a small patch to fix electron/electron#5665
RenderWidgetHostViewChildFrame was missing some functions, I tried to keep the implementation as small as possible for easier maintenance.

@IsaiahJTurner
Copy link

@brenca I think something happened with copy and pasting source changes.

@brenca
Copy link
Contributor Author

brenca commented Aug 30, 2016

@IsaiahJTurner What do you mean?

@IsaiahJTurner
Copy link

Take that back. I hadn't seen a .patch before. I'll test it shortly, thanks for doing this!

@brenca
Copy link
Contributor Author

brenca commented Aug 30, 2016

:) It was actually an issue with chromium's code, this is why I made a patch file to fix it. Also, you might want to wait until @zcbenz pulls this in (if he will :) ) and it gets included in the next electron release, since building a custom libchromiumcontent can easily take a full day (and most of it is just the building!), if you don't have machine specifically made for this kind of stuff. I couldn't test this out on Mac, but I did test it on Windows (the screenshot I added) and the subscription seems to be working perfectly now.

@zeke
Copy link
Contributor

zeke commented Aug 31, 2016

💰

@gerhardberger
Copy link
Contributor

I tried it out on macOS and works like a charm! 👌

@zcbenz
Copy link
Contributor

zcbenz commented Sep 1, 2016

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

beginFrameSubscription doesn't work with webview
5 participants