New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for webviews using default (empty) BeginFrameSubscription implementation #227

Merged
merged 1 commit into from Sep 1, 2016

Conversation

Projects
None yet
5 participants
@brenca
Member

brenca commented Aug 30, 2016

This PR adds a small patch to fix electron/electron#5665
RenderWidgetHostViewChildFrame was missing some functions, I tried to keep the implementation as small as possible for easier maintenance.

@IsaiahJTurner

This comment has been minimized.

IsaiahJTurner commented Aug 30, 2016

@brenca I think something happened with copy and pasting source changes.

@brenca

This comment has been minimized.

Member

brenca commented Aug 30, 2016

@IsaiahJTurner What do you mean?

@IsaiahJTurner

This comment has been minimized.

IsaiahJTurner commented Aug 30, 2016

Take that back. I hadn't seen a .patch before. I'll test it shortly, thanks for doing this!

@brenca

This comment has been minimized.

Member

brenca commented Aug 30, 2016

:) It was actually an issue with chromium's code, this is why I made a patch file to fix it. Also, you might want to wait until @zcbenz pulls this in (if he will :) ) and it gets included in the next electron release, since building a custom libchromiumcontent can easily take a full day (and most of it is just the building!), if you don't have machine specifically made for this kind of stuff. I couldn't test this out on Mac, but I did test it on Windows (the screenshot I added) and the subscription seems to be working perfectly now.

@zeke

This comment has been minimized.

Member

zeke commented Aug 31, 2016

💰

@gerhardberger

This comment has been minimized.

Member

gerhardberger commented Aug 31, 2016

I tried it out on macOS and works like a charm! 👌

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Sep 1, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment