This repository has been archived by the owner on Jan 6, 2023. It is now read-only.
Add a patch to fix long jitter buffer delays with Opus and DTX (2.0.x edition) #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As mentioned in #532 this is a critical issue for WebRTC services using DTX. We should try to get it in Electron 2.0.x. |
|
@ajmacd The patch has exactly the same changes as the upstream repo, with no modifications, right? |
ckerr
suggested changes
May 1, 2018
There was a problem hiding this comment.
The main discussion should probably take place at #532
Marking as "Request changes" here to explicitly pause this PR until 532 questions are resolved.
On top of that, it seems unsafe to take an optional field-test switch from upstream and make it unconditionally enabled in a stabilization branch here.
ckerr
approved these changes
May 2, 2018
This was referenced May 2, 2018
|
@alexeykuzmin Good point. At least in this case, the changes were identical to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the patch in #532 to
electron-2-0-x.