Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

build: Ship libbase_static.a for macOS/Linux (3.0.x) #611

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

poiru
Copy link
Contributor

@poiru poiru commented Jul 24, 2018

This cherry-picks for #609 for 3.0.x.

This cherry-picks for #609 for 3.0.x.
@poiru poiru changed the title build: Ship libbase_static.a for macOS/Linux build: Ship libbase_static.a for macOS/Linux (3.0.x) Jul 24, 2018
@poiru poiru requested a review from deepak1556 July 24, 2018 16:55
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ckerr ckerr merged commit 3c2f0be into electron-3-0-x Jul 24, 2018
@ckerr ckerr deleted the ship-base-static-3-0-x branch July 24, 2018 20:03
poiru added a commit to electron/electron that referenced this pull request Jul 24, 2018
poiru added a commit to electron/electron that referenced this pull request Jul 24, 2018
nornagon pushed a commit to electron/electron that referenced this pull request Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants