fix: Allow downloading of x64 binary for arm64 snapshots #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
|
@raspberrypifan unfortunately this will not fix #23 as it will download an x64 binary on arm/arm64 OSes. That binary will not run on arm/arm64. Those binaries are intended to be run on an x64 to create a snapshot that can then be used on arm/arm64. In electron/electron#17561 we removed native arm/arm64 mksnapshot binaries due to chromium incompatibilities. |
jkleinsc
changed the title
|
Merging as this PR does fix downloading the x64 arm64 binary on x64 platforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file for arm64 is named "mksnapshot-vX.Y.Z-linux-arm64-x64.zip", and currently this script tries to download "mksnapshot-vX.Y.Z-linux-arm64.zip" and fails on arm64. The same applies for armv7l.