Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use promise with async #47

Merged
merged 17 commits into from
May 31, 2016
Merged

Use promise with async #47

merged 17 commits into from
May 31, 2016

Conversation

sethlu
Copy link
Contributor

@sethlu sethlu commented May 30, 2016

Applies Bluebird Promise over index.js, introducing in API .signAsync() and .flatAsync() both returning promise obj.

@develar
Use async walk
7fac4f4 
* Don't use sync method to collect paths to sign
* Don't read the whole file content to check is binary or not — use `isbinaryfile` module.

Closes electron#35
@sethlu sethlu added this to the Next Release milestone May 30, 2016
@sethlu sethlu changed the title Use promise Use promise with async May 30, 2016
@sethlu sethlu mentioned this pull request May 30, 2016
Closed
@sethlu
Copy link
Contributor Author

sethlu commented May 30, 2016 •
edited
Loading

@develar Let me know if there be any suggestions 😸 It's still a working draft so many possible changes are expected. Probably a next release with this eventually merged will be a beta lol.

@sethlu
Copy link
Contributor Author

sethlu commented May 31, 2016

This is almost a complete rewrite of electron-osx-sign. From testing possible error cases, it's quite convincing that the code migration doesn't affect much of the performance, but now allowing better async with Bluebird. All builds from Electron v0.24.0 to the most recent v1.2.0 passing tests, I'm merging this now so future PRs could be based on this standard, including #43 and #44. Again, electron-osx-sign is currently only providing a standard signing; however, very soon will the ElectronTeamID acknowledged in app bundle. Thanks @develar for making a start on these notable changes 😺; literally everything is changed, except the APIs exported, so electron-packager and electron-builder or other modules dependent on this shouldn't be affected.

@sethlu sethlu merged commit c1803e0 into electron:master May 31, 2016
@sethlu sethlu deleted the use-promise branch May 31, 2016 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Release 0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sethlu @develar