Introduce entitlements automation #44
Conversation
- Fixes electron#41 - Added opts.version/—version to apply suitable pre/post operations - Added opts[‘pre-auto-entitlement-app-group’] / —pre-auto-entitlement-app-group to trigger entitlement automation with app group setting
sethlu
force-pushed
the
automate-entitlements-by-info-plist
branch
from
bef7033
to
184985a
Compare
sethlu
force-pushed
the
automate-entitlements-by-info-plist
branch
from
806a658
to
435d08b
Compare
Deprecate `pre-auto-entitlement-app-group` and introduce `no-pre-auto-entitlements`
sethlu
force-pushed
the
automate-entitlements-by-info-plist
branch
from
0fa4517
to
696f3f4
Compare
| @@ -384,7 +384,7 @@ function signApplicationAsync (opts) { | |||
| }) | |||
| .then(function () { | |||
| debuglog('Signing... ' + opts.app) | |||
| execFileAsync('codesign', args.concat('--entitlements', opts.entitlements, opts.app)) | |||
There was a problem hiding this comment.
@develar This may have caused a branching in async methods with thenables I think. 😕
What happened then is that verification (which should be after this promise fulfills) starts at a same time!? so code cannot be verified. But with the fix on the right, the verification starts after signing the app on this line.
I was slightly confused when encountering this.
There was a problem hiding this comment.
Sorry, don't quite understand what do you mean.
What happened then is that verification (which should be after this promise fulfills) starts at a same time!?
How it can be? It is called in handler promise.then, so, it is ok.
return promise
.then(function () {
// Verify code sign
debuglog('Verifying code sign...')
There was a problem hiding this comment.
I am not sure, but my understanding back then is that: If a promise is returned from a function, that function .then() only works after the promise's fulfilled. However, if nothing's returned from a function yet a promise is created, that function .then() starts immediately instead of waiting for that promise to be fulfilled... Not sure if this is an intelligible saying. 😖
Anyway... It works with the return lol.
Fix #41
Blocked by #45