Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--arch should default to host arch #36

Closed
sindresorhus opened this issue May 18, 2015 · 10 comments
Closed

--arch should default to host arch #36

sindresorhus opened this issue May 18, 2015 · 10 comments
Assignees
Labels
enhancement Feature request
Milestone

Comments

@sindresorhus
Copy link
Contributor

Good defaults again. Less config.

@junosuarez
Copy link
Contributor

It's not clear to me that this is the best default. It's not the broadest compatibility-speaking. If you're building for your own machine, then it should default to whatever your current arch is (granted, in 2015, it's likely x64, but I digress). If you're running electron-packager to cross-build for a different target arch, then it could be anything that electron supports.

@max-mapper
Copy link
Contributor

max-mapper commented May 18, 2015 via email

@sindresorhus
Copy link
Contributor Author

I think defaulting to the system arch would be weird as we're talking about packaging the app, not running. You'd want it to be predictable between computers.

I just want less config. And having x64 as default means I wouldn't have to spell it out on my OS X and Linux targets.

@max-mapper
Copy link
Contributor

there are a good percentage of 32 bit linux users still, so im on the fence
about this, seems like it could make it more confusing for linux 32/
windows users

On Mon, May 18, 2015 at 3:38 PM, Sindre Sorhus notifications@github.com
wrote:

I think defaulting to the system arch would be weird as we're talking
about packaging the app, not running. You'd want it to be predictable
between computers.

I just want less config. And having x64 as default means I wouldn't have
to spell it out on my OS X and Linux targets.


Reply to this email directly or view it on GitHub
#36 (comment)
.

@sindresorhus
Copy link
Contributor Author

I don't see what's confusing. It's just about a documented default. If you want to compile for 32bit too you just then add the --arch option.

@max-mapper
Copy link
Contributor

@sindresorhus its just that adding a mac/linux centric default for no good reason just feels weird to me personally, i'd rather fix your problem of not wanting to have to specify complex config with other options like #40

@zeke
Copy link
Contributor

zeke commented Aug 12, 2016

It seems like the best option is use a default that will work for all users. It looks like the --all option shipped in #40 may have allayed some of the config frustration. @sindresorhus are you cool with closing this?

@zeke zeke added the enhancement Feature request label Aug 12, 2016
@sindresorhus
Copy link
Contributor Author

Still makes sense. Not everyone can use the --all option and without, electron-packager requires a lot of config that could have good defaults. But I switched to electron-builder, so I don't really care anymore.

@malept
Copy link
Member

malept commented Aug 12, 2016

I would rather default to whatever the arch is of the host (which, admittedly, is likely to be x64).

@malept malept changed the title --arch should default to x64 --arch should default to host arch Aug 21, 2016
@malept malept added this to the 8.0.0 milestone Aug 21, 2016
@malept malept self-assigned this Aug 21, 2016
@malept
Copy link
Member

malept commented Aug 21, 2016

Defaulting to the host arch has the added benefit of less config when your Electron app requires native modules.

malept referenced this issue in malept/electron-packager Aug 21, 2016
The defaults are the host's arch and platform values.

Fixes #36.
malept referenced this issue in malept/electron-packager Aug 21, 2016
The defaults are the host's arch and platform values.

Fixes #36.
malept referenced this issue in malept/electron-packager Aug 24, 2016
The defaults are the host's arch and platform values.

Fixes #36.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request
Projects
None yet
Development

No branches or pull requests

5 participants