-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--arch
should default to host arch
#36
Comments
It's not clear to me that this is the best default. It's not the broadest compatibility-speaking. If you're building for your own machine, then it should default to whatever your current arch is (granted, in 2015, it's likely x64, but I digress). If you're running electron-packager to cross-build for a different target arch, then it could be anything that electron supports. |
if any thing we should default to `require('os').arch`, but even there it's
a little confusing UX wise
|
I think defaulting to the system arch would be weird as we're talking about packaging the app, not running. You'd want it to be predictable between computers. I just want less config. And having x64 as default means I wouldn't have to spell it out on my OS X and Linux targets. |
there are a good percentage of 32 bit linux users still, so im on the fence On Mon, May 18, 2015 at 3:38 PM, Sindre Sorhus notifications@github.com
|
I don't see what's confusing. It's just about a documented default. If you want to compile for 32bit too you just then add the |
@sindresorhus its just that adding a mac/linux centric default for no good reason just feels weird to me personally, i'd rather fix your problem of not wanting to have to specify complex config with other options like #40 |
It seems like the best option is use a default that will work for all users. It looks like the |
Still makes sense. Not everyone can use the |
I would rather default to whatever the arch is of the host (which, admittedly, is likely to be x64). |
--arch
should default to x64--arch
should default to host arch
Defaulting to the host arch has the added benefit of less config when your Electron app requires native modules. |
The defaults are the host's arch and platform values. Fixes #36.
The defaults are the host's arch and platform values. Fixes #36.
The defaults are the host's arch and platform values. Fixes #36.
Good defaults again. Less config.
The text was updated successfully, but these errors were encountered: