Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give warnings when using an invalid arch/platform combination #562

Closed
seiyria opened this issue Jan 17, 2017 · 2 comments
Closed

give warnings when using an invalid arch/platform combination #562

seiyria opened this issue Jan 17, 2017 · 2 comments
Labels

Comments

@seiyria
Copy link

seiyria commented Jan 17, 2017

Please describe your issue: I accidentally was using --arch=ia32 and --platform=darwin and was getting absolutely no output from electron-packager. Turns out I have to use --arch=x64.

Console output when you run electron-packager with the environment variable DEBUG=electron-packager. Please include the stack trace if one exists.

posys seiyria$ ./node_modules/.bin/electron-packager . --platform=darwin --arch=ia32
posys seiyria$ ./node_modules/.bin/electron-packager . --platform=darwin --arch=x64
Packaging app for platform darwin x64 using electron v1.4.14
Wrote new app to /Users/seiyria/GitHub/posys/Posys-darwin-x64

What command line arguments are you passing? Alternatively, if you are using the API, what
parameters are you passing to the packager() function?

--arch=ia32 --platform=darwin

Please provide either a failing minimal testcase (with a link to the code) or detailed steps to
reproduce your problem. Using electron-quick-start
is a good starting point.

It should work on any electron-packager usage, but the project I'm using it on is here.

@malept malept added bug 🐛 help wanted Needs a contributor from the community labels Jan 17, 2017
@malept malept changed the title give errors when using an invalid arch/platform combination give warnings when using an invalid arch/platform combination Jan 18, 2017
@malept
Copy link
Member

malept commented Jan 18, 2017

Thanks for the suggestion! I'd rather give warnings than errors.

@seiyria
Copy link
Author

seiyria commented Jan 18, 2017

A warning would be fantastic too. Anything to let me know that I'm doing something dumb is better than silence!

malept added a commit that referenced this issue Jun 14, 2017
It already errors when the arch/platform is not recognized, this is the
case where the combination is not supported by Electron, e.g.
armv7l/darwin.

Also allows for non-official archs/platforms when a download.mirror is
specified.

Fixes #562.
@malept malept removed the help wanted Needs a contributor from the community label Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants