Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux/ia32 warning moved from Packager to @electron/get #1016

Merged
merged 1 commit into from Jun 19, 2019

Conversation

malept
Copy link
Member

@malept malept commented Jun 19, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Reverts #957 and requires @electron/get@^1.3.0, as @electron/get has the warning instead of Packager.

@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #1016 into v14-develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           v14-develop   #1016   +/-   ##
===========================================
  Coverage          100%    100%           
===========================================
  Files               13      13           
  Lines              677     677           
===========================================
  Hits               677     677
Impacted Files Coverage Δ
src/targets.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cd00d4...4eb2416. Read the comment docs.

@malept malept merged this pull request into v14-develop Jun 19, 2019
@malept malept deleted the linux-ia32-get-warning branch June 19, 2019 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant